Skip to content

Fix previous deleted and rediscovered MQTT devices are not placed in suggested area#170985

Closed
jbouwh wants to merge 2 commits into
devfrom
mqtt-update-suggested-area
Closed

Fix previous deleted and rediscovered MQTT devices are not placed in suggested area#170985
jbouwh wants to merge 2 commits into
devfrom
mqtt-update-suggested-area

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented May 17, 2026 •
edited
Loading

Proposed change

When an MQTT device is removed, its deleted entry reference is kept.
When an MQTT device is then readded, a suggested area in the configuration should be respected, instead of restoring the area of the deleted entry.

Note that this fix will only work if the entity has a device configuration and the device was removed from the device registry before it was rediscovered.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 14:32
@jbouwh jbouwh requested review from bdraco and emontnemery as code owners May 17, 2026 14:32
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 17, 2026

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@jbouwh jbouwh changed the title Fix deleted MQTT devices not placed in suggested area Fix previous deleted and rediscoovered MQTT devices are not placed in suggested area May 17, 2026
@jbouwh jbouwh changed the title Fix previous deleted and rediscoovered MQTT devices are not placed in suggested area Fix previous deleted and rediscovered MQTT devices are not placed in suggested area May 17, 2026
Copilot AI reviewed May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jbouwh jbouwh added this to the 2026.6.0b0 milestone May 18, 2026
arturpragacz
arturpragacz requested changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arturpragacz arturpragacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an MQTT device is then readded, a suggested area in the configuration should be respected, instead of restoring the area of the deleted entry.

I disagree. Why should MQTT behave differently here than every other integration?

@home-assistant home-assistant Bot marked this pull request as draft May 18, 2026 23:35
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 18, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented May 19, 2026

When an MQTT device is then readded, a suggested area in the configuration should be respected, instead of restoring the area of the deleted entry.

I disagree. Why should MQTT behave differently here than every other integration?

MQTT is different because setting an area was long supported before deleted entities were stored. Als there are similar options like change the entity ID that have been implemented through MQTT. It is not that a device just can be updated. It must be deleted first, and also no other entries should have links to the same device entry.

Systems like Zigbee2MQTT make use of this feature, and may be it was never meant to be this way, I think it makes sense to allow users to rediscover devices from their external eco system.

@emontnemery what do you think?

@emontnemery
Copy link
Copy Markdown
Contributor

emontnemery commented May 19, 2026

The suggested_area feature was probably a bad idea from the start.
I think we discussed this before, and suggested_area is not the correct way to manage areas, we have a websocket API for that.

I suggest we close this PR without merge.

@jbouwh jbouwh closed this May 19, 2026
@jbouwh jbouwh deleted the mqtt-update-suggested-area branch May 19, 2026 12:05
@TIRTAGT
Copy link
Copy Markdown

TIRTAGT commented May 19, 2026

The suggested_area feature was probably a bad idea from the start.

I think we discussed this before, and suggested_area is not the correct way to manage areas, we have a websocket API for that.

That property is used heavily on my roaming setup, not all IoT devices are fixed in place @emontnemery

Now that it's broken, hopefully HA WebSocket can handle some polling abuse for many devices (hundred in my case) and have it updated on the official docs.

@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@arturpragacz arturpragacz arturpragacz requested changes

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@emontnemery emontnemery

Labels

bugfix by-code-owner cla-signed core has-tests integration: mqtt Quality Scale: platinum

Projects

None yet

Milestone

2026.6.0b0

Development

Successfully merging this pull request may close these issues.

Newly discovered devices via MQTT are no more in the suggested_area

6 participants

@jbouwh @emontnemery @TIRTAGT @arturpragacz @bdraco